Matthias Clasen [Sat, 29 Nov 2014 22:06:04 +0000 (17:06 -0500)]
HighContrast: in app notification padding
Copied the Adwaita treatment from
e5d34372c4f163e49fb1e0a95f53445f6fa13f2c
https://bugzilla.gnome.org/show_bug.cgi?id=740857
Lapo Calamandrei [Sat, 29 Nov 2014 17:46:06 +0000 (18:46 +0100)]
HighContrast: scale slider fix and cleanup
Set GtkScale margins on the .trough component so the .slider
doesn't inherit them vanishing.
Remove a bunch trailing white spaces in the process.
Lapo Calamandrei [Sat, 29 Nov 2014 17:21:12 +0000 (18:21 +0100)]
Adwaita: set scale with marks trough margin where it belongs to
Matthias Clasen [Sat, 29 Nov 2014 05:26:52 +0000 (00:26 -0500)]
Beautify example Makefiles a bit
Matthias Clasen [Sat, 29 Nov 2014 05:01:49 +0000 (00:01 -0500)]
GtkModelMenuItem: put some space between icon and label
This makes the bloatpad icons menu look slightly less odd.
Matthias Clasen [Sat, 29 Nov 2014 04:55:03 +0000 (23:55 -0500)]
Make include order consistent in example applications
Pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=740537
Benjamin Otte [Sat, 29 Nov 2014 02:33:47 +0000 (03:33 +0100)]
range: Implement :hover for the whole widget
Benjamin Otte [Sat, 29 Nov 2014 02:27:36 +0000 (03:27 +0100)]
range: Handle redraws inside update_mouse_location
This way, we can do finer-grained invalidation. Plus, we get to not
duplicate all the queue_draw() calls.
Benjamin Otte [Sat, 29 Nov 2014 02:23:58 +0000 (03:23 +0100)]
range: Properly queue draws when doing a drag
The dragged area needs to be marked as :active during the drag.
Benjamin Otte [Sat, 29 Nov 2014 02:20:18 +0000 (03:20 +0100)]
range: Remove unused variable
The variable was TRUE from the beginning and only ever set to TRUE.
Benjamin Otte [Sat, 29 Nov 2014 02:18:50 +0000 (03:18 +0100)]
range: No need to update mouse location when starting a drag
The mouse position doesn't change here. Plus, all callers have just
updated it anyway.
Benjamin Otte [Sat, 29 Nov 2014 01:39:47 +0000 (02:39 +0100)]
range: Only call needed functions from adjustment changes
No need to recalc the whole range when all that changed was the slider.
Benjamin Otte [Sat, 29 Nov 2014 01:17:27 +0000 (02:17 +0100)]
range: Implement gtk_range_calc_stepper_sensitivity() properly
Benjamin Otte [Sat, 29 Nov 2014 00:47:31 +0000 (01:47 +0100)]
range: Implement gtk_range_calc_slider() properly
Benjamin Otte [Sat, 29 Nov 2014 00:39:09 +0000 (01:39 +0100)]
range: Refactor a function
This is in preparation for more places that want to
queue_draw_location().
Benjamin Otte [Sat, 29 Nov 2014 00:23:54 +0000 (01:23 +0100)]
range: Introduce finer-grained invalidation
The invalidation doesn't do anything yet, it just clears up what
actually needs recalculation.
Benjamin Otte [Sat, 29 Nov 2014 00:15:36 +0000 (01:15 +0100)]
range: Changing the min slider size requires a resize
Benjamin Otte [Thu, 27 Nov 2014 23:24:06 +0000 (00:24 +0100)]
range: No need to frce a recalc
A resize will already trigger a recalc, so no need to explicitly trigger
it.
Benjamin Otte [Sat, 29 Nov 2014 00:55:06 +0000 (01:55 +0100)]
widget: Clarify some corner cases
I checked Cairo source code (actually pixman, as Cairo just passes
through) to make sure that the behavior stays identical: negative values
cause an error message from pixman, zero is allowed. Both return an
empty region which gtk_widget_queue_draw_region() would then proceed to
ignore.
Jasper St. Pierre [Fri, 28 Nov 2014 22:03:50 +0000 (14:03 -0800)]
Fix build
Jakub Steiner [Fri, 28 Nov 2014 14:47:58 +0000 (15:47 +0100)]
Provide symbolic variants of app icons
Install symbolic variants of the app icons for gtk3-demo and
gtk3-widget-factory. These are necessary for the HighContrast theme.
https://bugzilla.gnome.org/show_bug.cgi?id=740447
Matthias Clasen [Fri, 28 Nov 2014 17:34:56 +0000 (12:34 -0500)]
docs: Add a missing word
Matthias Clasen [Fri, 28 Nov 2014 17:32:26 +0000 (12:32 -0500)]
Drop an unused variable
Lapo Calamandrei [Fri, 28 Nov 2014 16:03:53 +0000 (17:03 +0100)]
Adwaita: GtkTreeView insensitive state style.
See https://bugzilla.gnome.org/show_bug.cgi?id=740770.
Matthias Clasen [Fri, 28 Nov 2014 03:56:46 +0000 (22:56 -0500)]
inspector: Simplify some code
Yosef Or Boczko [Mon, 24 Nov 2014 17:09:02 +0000 (19:09 +0200)]
GtkStackSwitcher: Make the buttons fill vertically
It fix some cases with different height for the buttons,
like with Hebrew character.
https://bugzilla.gnome.org/show_bug.cgi?id=740642
Matthias Clasen [Thu, 27 Nov 2014 23:22:52 +0000 (18:22 -0500)]
Avoid a critical
gtk_window_get_focus can return NULL, deal with it.
https://bugzilla.gnome.org/show_bug.cgi?id=740812
Matthias Clasen [Thu, 27 Nov 2014 14:42:58 +0000 (09:42 -0500)]
Render shadows for half-tiled windows
Without this, side-by-side half-tiled windows are hard to discern.
https://bugzilla.gnome.org/show_bug.cgi?id=708857
Josef Andersson [Thu, 27 Nov 2014 22:01:44 +0000 (22:01 +0000)]
Updated Swedish translation
Marco Trevisan (Treviño) [Thu, 27 Nov 2014 18:25:55 +0000 (19:25 +0100)]
mir: clear screen, keymap and event source when disposing dpy
Marek Kasik [Thu, 27 Nov 2014 16:04:47 +0000 (17:04 +0100)]
printing: Fix build with CUPS older than 1.6
Define missing functions ippFirstAttribute(), ippNextAttribute()
and macro ippGetCollection(). These were added in CUPS 1.6.
https://bugzilla.gnome.org/show_bug.cgi?id=740358
Leo Wolf [Wed, 26 Nov 2014 20:18:36 +0000 (20:18 +0000)]
printing: Fix origin for scaled, rotated pages
The calls to cairo_translate in
_gtk_print_context_rotate_according_to_orientation,
_gtk_print_context_reverse_according_to_orientation and
_gtk_print_context_translate_into_margin assume an unscaled context.
These functions should therefore be called before scaling the context,
otherwise the origin does not always end up in the top left corner.
https://bugzilla.gnome.org/show_bug.cgi?id=740742
Matthias Clasen [Thu, 27 Nov 2014 03:25:36 +0000 (22:25 -0500)]
x11: Handle obsolete selection requests without crashing
The ICCCM says:
If the specified property is None , the requestor is an obsolete client.
Owners are encouraged to support these clients by using the specified
target atom as the property name to be used for the reply.
Lets do that, instead of crashing.
https://bugzilla.gnome.org/show_bug.cgi?id=740613
Jasper St. Pierre [Thu, 27 Nov 2014 02:10:43 +0000 (18:10 -0800)]
gtkentry: Optimize GtkStyleContext usage
Jasper St. Pierre [Thu, 27 Nov 2014 02:10:36 +0000 (18:10 -0800)]
gtklabel: Optimize GtkStyleContext usage
Jasper St. Pierre [Thu, 27 Nov 2014 02:10:29 +0000 (18:10 -0800)]
gtkstylecontext: Optimize GtkStyleContext usage
Jasper St. Pierre [Thu, 27 Nov 2014 02:10:21 +0000 (18:10 -0800)]
gtktextdisplay: Optimize GtkStyleContext usage
Jasper St. Pierre [Thu, 27 Nov 2014 01:07:56 +0000 (17:07 -0800)]
gdkdisplay-x11: Don't do extra work when simply moving the window
We shouldn't bother recalculating all the visible regions and wiping
away the old updating areas if we're simply dragging the window around.
Matthias Clasen [Wed, 26 Nov 2014 23:38:43 +0000 (18:38 -0500)]
GtkSpinButton: Use the proper state
Use the style contexts current state when querying it.
Carlos Garnacho [Wed, 26 Nov 2014 14:30:52 +0000 (15:30 +0100)]
popover: Send key events only to the focus widget
gtk_window_propagate_key_event() will run unstopped from the focus widget up to the
popover if GDK_EVENT_PROPAGATE was returned along the chain, resulting in infinite
recursion. This could be just triggered by pressing some modifier key on an entry...
Sebastien Lafargue [Wed, 26 Nov 2014 12:53:30 +0000 (13:53 +0100)]
textbtree: Remove unneeded check
Benjamin Otte [Tue, 25 Nov 2014 22:21:48 +0000 (23:21 +0100)]
range: Remove unnecessary argument
It's always the same value passed in, so just use that value directly.
Benjamin Otte [Tue, 25 Nov 2014 22:13:21 +0000 (23:13 +0100)]
range: Query slider position instead of updating it
We're updating it later in the function, there's no need to do it here.
Benjamin Otte [Tue, 25 Nov 2014 22:12:08 +0000 (23:12 +0100)]
gtkrange: Fix copy/paste error
When factoring out a function in
b88584e7bae9bacbda8bd0d9868cbe50eb8e218d I forgot to adapt these values.
Benjamin Otte [Tue, 25 Nov 2014 21:00:11 +0000 (22:00 +0100)]
range: Setting stepper visibility requires a restyle
Benjamin Otte [Tue, 25 Nov 2014 20:57:58 +0000 (21:57 +0100)]
entry: Use correct state when computing icon padding
Emmanuele Bassi [Wed, 19 Nov 2014 14:43:10 +0000 (14:43 +0000)]
Freeze file system model during editing
If a file system event arrives while GtkFileChooserWidget is asking the
user to edit the name of a newly created folder, the file system model
will drop the row with the editable cell, and the user will have to
start from scratch.
This makes creating new directories impossible inside a directory with a
file currently being downloaded, for instance, and it's really unhelpful
to the user because the editable row simply disappears.
We already have a mechanism in place to freeze the file system model, so
we can reuse it between the add_editable() and the remove_editable()
calls.
https://bugzilla.gnome.org/show_bug.cgi?id=729927
Andre Heinecke [Mon, 24 Nov 2014 09:59:32 +0000 (10:59 +0100)]
Remove overzealous validity check for secrets
We directly get the length of the secret from the g_variant
and use it in a following g_strndup which ensures that the
resulting string is terminated.
This fixes reading secrets which were stored by system-config-printer.
https://bugzilla.gnome.org/show_bug.cgi?id=740612
Joanmarie Diggs [Thu, 20 Nov 2014 15:19:52 +0000 (10:19 -0500)]
GtkButtonAccessible: Stop emitting state-change signals for ATK_STATE_ARMED
ATK_STATE_ARMED is now deprecated. There is no replacement.
https://bugzilla.gnome.org/show_bug.cgi?id=740438
Emmanuele Bassi [Wed, 19 Nov 2014 15:50:55 +0000 (15:50 +0000)]
docs: Fix annotation for GtkCssProviderError
https://bugzilla.gnome.org/show_bug.cgi?id=740374
Jasper St. Pierre [Tue, 25 Nov 2014 19:21:21 +0000 (11:21 -0800)]
Revert part of "gtknotebook: Optimize GtkStyleContext usage"
This reverts part of commit
c71e2131345c929753a0128c780d679ce0c4ce6a.
This part was unfinished and was pushed simply to avoid the warnings.
Jasper St. Pierre [Tue, 25 Nov 2014 19:07:31 +0000 (11:07 -0800)]
gtkstylecontext: Add an optional warning when misusing GtkStyleContext
This allows someone to quickly debug more performance issues with
G_DEBUG=fatal-warnings.
Jasper St. Pierre [Tue, 25 Nov 2014 19:05:57 +0000 (11:05 -0800)]
gtkcellarea: Optimize GtkStyleContext usage
This is a bit bizarre, but the cell renderer can apply different
flags from the actual style context, and we should use those instead
of the widget flags.
Jasper St. Pierre [Tue, 25 Nov 2014 19:05:49 +0000 (11:05 -0800)]
gtknotebook: Optimize GtkStyleContext usage
Jasper St. Pierre [Tue, 25 Nov 2014 19:05:36 +0000 (11:05 -0800)]
gtkwindow: Optimize GtkStyleContext usage
Jasper St. Pierre [Tue, 25 Nov 2014 19:05:04 +0000 (11:05 -0800)]
deprecated/gtkstyle: Optimize GtkStyleContext usage
Even though this is deprecated, it's still initialized for every
screen at startup, so let's minimize the cost.
Jasper St. Pierre [Tue, 25 Nov 2014 01:07:01 +0000 (17:07 -0800)]
gtkentry: Pass the correct set of state flags to gtk_style_context_get*
This eliminates a lot of overhead in the CSS engine recalculating
cached CSS rules, and is overall the correct thing to do.
Jasper St. Pierre [Tue, 25 Nov 2014 00:56:23 +0000 (16:56 -0800)]
gtkwidget: Remove unnecessary code in get_state_flags
Any time has_focus is called, we will call gtk_widget_update_state_flags
which will assign the state flags properly.
Benjamin Otte [Tue, 25 Nov 2014 18:33:18 +0000 (19:33 +0100)]
testsuite: Add a bunch of parsing tests for :not()
Benjamin Otte [Tue, 25 Nov 2014 18:31:23 +0000 (19:31 +0100)]
cssselector: Add none selector
We apparently didn't yet parse :not(*), so write a selector for this.
Benjamin Otte [Tue, 25 Nov 2014 18:15:36 +0000 (19:15 +0100)]
cssselector: Add initial support for :not()
:not() works for names, ids, classes and pseudoclasses based on states.
It does not yet work for positional pseudoclasses (like :last-child or
:even) as there is region madness going on with those.
Benjamin Otte [Tue, 25 Nov 2014 17:51:13 +0000 (18:51 +0100)]
cssselector: Macroify simple selectors
This is in preparation for the next commits.
Benjamin Otte [Fri, 21 Nov 2014 07:50:38 +0000 (08:50 +0100)]
range: Don't duplicate work
The adjustment value being equal is checked by
gtk_adjustment_set_value() and the necessity of calc_layout() is handled
by the value_changed signal handler.
Benjamin Otte [Fri, 21 Nov 2014 07:29:37 +0000 (08:29 +0100)]
range: Don't invalidate layout when computing marks
We now have a function to compute a slider position. Use that one
instead.
Benjamin Otte [Fri, 21 Nov 2014 07:24:51 +0000 (08:24 +0100)]
range: Split out a function
The position of a slider for a given value is something we care a
lot about and jump through hoops to get. See next commit for example.
Benjamin Otte [Fri, 21 Nov 2014 07:15:54 +0000 (08:15 +0100)]
range: Remove 2 variables
Instead, compute their value on-demand.
Benjamin Otte [Fri, 21 Nov 2014 07:00:52 +0000 (08:00 +0100)]
range: Remove unused variable
Benjamin Otte [Fri, 21 Nov 2014 06:26:19 +0000 (07:26 +0100)]
scale: Always be flippable
GtkRange only flips horizontal ranges, so there's no need to unset it
for vertical scales.
Also, set_flippable() is a cute name.
Benjamin Otte [Fri, 21 Nov 2014 06:16:12 +0000 (07:16 +0100)]
range: Simplify defines
- Delete unused defines
- Don't have 2 defines that are multiplied later
Benjamin Otte [Tue, 18 Nov 2014 17:49:17 +0000 (18:49 +0100)]
range: Deprecate detail strings in class struct
... and stop setting them.
Benjamin Otte [Tue, 18 Nov 2014 17:21:49 +0000 (18:21 +0100)]
range: Remove unused detail quarks
Benjamin Otte [Tue, 18 Nov 2014 16:48:07 +0000 (17:48 +0100)]
range: Remove unused variable
Matthias Clasen [Tue, 25 Nov 2014 13:42:26 +0000 (08:42 -0500)]
inspector: Make close buttons in search bars have no relief
Make our home-grown searchbar lookalike look more alike.
Carlos Garnacho [Tue, 25 Nov 2014 12:54:25 +0000 (13:54 +0100)]
popover: Forward key events to focus widget while visible/modal
This is the expected behavior while the popover keeps the grab, leaving
this up to the toplevel implementation gives place to key handlers
connected there to handle the event otherwise, and maybe redirect key
events somewhere else.
Matthias Clasen [Tue, 25 Nov 2014 05:14:47 +0000 (00:14 -0500)]
GtkStack: silently ignore visible-child-name set to NULL
This can happen when loading empty stacks in glade.
Matthias Clasen [Tue, 25 Nov 2014 01:36:00 +0000 (20:36 -0500)]
inspector: minor cleanup
Ray Strode [Fri, 21 Nov 2014 19:17:06 +0000 (14:17 -0500)]
testsuite: add hide-titlebar-when-maximized test for GtkWindow
This commit adds a test that checks whether or not
hide-titlebar-when-maximized can be set before the window is
realized.
https://bugzilla.gnome.org/show_bug.cgi?id=740287
Matthias Clasen [Mon, 24 Nov 2014 15:01:54 +0000 (10:01 -0500)]
Make scale=2 work again
There was a leftover HAVE_CAIRO_SURFACE_SET_DEVICE_SCALE ifdef
that broke things, now that we don't use this define anymore.
Chun-wei Fan [Mon, 24 Nov 2014 03:05:18 +0000 (11:05 +0800)]
gdkgl.c: Avoid GCCism in Pointer Arithmetic
NULL-plus-something could be seen by the compiler to attempt to do
arithmetic with void *, which is a GCCism. Instead, do the math normally
and cast the results as a void *.
https://bugzilla.gnome.org/show_bug.cgi?id=740605
Matthias Clasen [Mon, 24 Nov 2014 11:49:19 +0000 (06:49 -0500)]
Keep gtk_window_set_hide_titlebar_when_maximized working
This broke in
510c2cdfb6362568f4384790dc06e0b1b4aba0e5.
https://bugzilla.gnome.org/show_bug.cgi?id=740287
Matthias Clasen [Mon, 24 Nov 2014 01:34:26 +0000 (20:34 -0500)]
Bump version
Matthias Clasen [Sat, 22 Nov 2014 02:42:52 +0000 (21:42 -0500)]
3.15.2
Matthias Clasen [Mon, 24 Nov 2014 00:30:14 +0000 (19:30 -0500)]
Add missing api to the docs
Matthias Clasen [Mon, 24 Nov 2014 00:16:49 +0000 (19:16 -0500)]
GtkModelButton: Add docs
Matthias Clasen [Sun, 23 Nov 2014 23:52:45 +0000 (18:52 -0500)]
Update expected results
Matthias Clasen [Sun, 23 Nov 2014 23:29:04 +0000 (18:29 -0500)]
notify test: Exclude a few new properties
The button properties don't make sense on GtkModelButton (indicating
that GtkModelButton should really not be a GtkButton subclass).
Matthias Clasen [Sun, 23 Nov 2014 23:25:35 +0000 (18:25 -0500)]
GtkGLArea: avoid extraneous property notifications
Matthias Clasen [Sun, 23 Nov 2014 20:05:01 +0000 (15:05 -0500)]
GtkModelButton: specify the proper default values
Caught by the defaultvalue test: ::text starts out as "", and
::iconic should be FALSE by default.
Carlos Garnacho [Tue, 11 Nov 2014 11:07:24 +0000 (12:07 +0100)]
wayland: Pass shadow width to the compositor
Use xdg_surface_set_window_geometry() to tell the compositor about the
shadow widths, this makes some gnome-shell/mutter features (edge resistance,
frames around windows in the overview, side maximization, ...) work alright
with GTK+.
In order to add this, some other places in gdkwindow-wayland had to gain
some knowledge about margins:
- xdg_surface_configure() now syncs the shadow after applying the state,
and gdk_wayland_window_set_shadow_width() possibly reconfigures the
window in order to preserve window geometry. This is necessary to keep
shadows in sync with state/geometry changes, as this does not happen
all at once.
- xdg_popups relative to an xdg_surface are shown relative to buffer
coordinates, so the left/top margins must be added there.
https://bugzilla.gnome.org/show_bug.cgi?id=736742
Matthias Clasen [Sun, 23 Nov 2014 02:37:39 +0000 (21:37 -0500)]
inspector: Show object title in menu tab
Matthias Clasen [Sun, 23 Nov 2014 02:33:57 +0000 (21:33 -0500)]
inspector: Add menu models to the tree
Add both the appmenu and the menubar models as children of the
application, if they exist.
Matthias Clasen [Sun, 23 Nov 2014 01:56:49 +0000 (20:56 -0500)]
inspector: Show object title in size groups tab
Matthias Clasen [Sun, 23 Nov 2014 01:13:26 +0000 (20:13 -0500)]
inspector: Show object title in data tab
Matthias Clasen [Sat, 22 Nov 2014 21:21:39 +0000 (16:21 -0500)]
inspector: Show object title on the style property list
As with the property list, this replaces the search bar by
a stack containing a search entry.
Matthias Clasen [Sat, 22 Nov 2014 21:21:17 +0000 (16:21 -0500)]
inspector: Show object title on selector tab
Matthias Clasen [Sat, 22 Nov 2014 20:40:24 +0000 (15:40 -0500)]
inspector: Show object title in actions tab
Matthias Clasen [Sat, 22 Nov 2014 18:54:16 +0000 (13:54 -0500)]
inspector: Show object title in hierarchy tab
Matthias Clasen [Sat, 22 Nov 2014 18:41:21 +0000 (13:41 -0500)]
inspector: Show object title in the classes tab
Matthias Clasen [Sat, 22 Nov 2014 18:26:53 +0000 (13:26 -0500)]
inspector: Show object title in the css tab
Matthias Clasen [Sat, 22 Nov 2014 18:12:41 +0000 (13:12 -0500)]
inspector: Show object title in the gestures tab